Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Import model #30345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjankowski
Copy link
Contributor

Attempting to remove the deprecated code from #21054

@renchap
Copy link
Sponsor Member

renchap commented May 17, 2024

This needs to be merged before we release our next major update, as it will prevent to update from a pre-4.2 version to the version containing this.

@ClearlyClaire
Copy link
Contributor

This needs to be merged before we release our next major update, as it will prevent to update from a pre-4.2 version to the version containing this.

You meant “after we release our next major update”?

@renchap
Copy link
Sponsor Member

renchap commented May 20, 2024

No, before we release it? So people can upgrade to the latest 4.x release (and we know they will have done the migration) then upgrade to 5.0 (which will require you to be up-to-date on the latest 4.x before upgrading to the next major)

@ClearlyClaire
Copy link
Contributor

Ok, I think we do agree, I just was confused by your initial post as it seemed to imply the earlier it was merged, the better.

The cost of merging it early is breaking in-progress imports for instances updating from pre-4.2.0 to a release containing this change.

The cost of merging it late is carrying “dead” code for longer.

I agree that 5.0 sounds like a good breakpoint to get rid of this.

Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants